Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FYI: Firefox 80 / macOS / OS X / Source Code Pro font black on dark grey text, incorrect rendering. #2694

Closed
kneufeld opened this issue Sep 17, 2020 · 2 comments
Closed

FYI: Firefox 80 / macOS / OS X / Source Code Pro font black on dark grey text, incorrect rendering. #2694

kneufeld opened this issue Sep 17, 2020 · 2 comments
Labels
docs/website theme

Comments

@kneufeld
Copy link

This is not a bug or feature request, just a bit of knowledge to maybe help the next person who runs into the same problem as I did...

All of a sudden code snippets on the web had black on dark grey and they were all using highlight.js so I naturally assumed that highlight.js was to blame. It wasn't.

It turns out that if you're using Firefox 80 on OSX with the font Source Code Pro then you'll hit bug

https://bugzilla.mozilla.org/show_bug.cgi?id=1520157

and my original bug:

https://bugzilla.mozilla.org/show_bug.cgi?id=1665427

It turns out that highlight.js is really popular and this bug showed itself all over the place...

Anyhow, feel free to close this, hopefully the google machine will index it soon.
@kneufeld kneufeld added the enhancement An enhancement or new feature label Sep 17, 2020
@joshgoebel joshgoebel changed the title black on dark grey text, incorrect rendering FYI: Firefox 80 / OS X / Source Code Pro font black on dark grey text, incorrect rendering. Sep 17, 2020
@joshgoebel joshgoebel changed the title FYI: Firefox 80 / OS X / Source Code Pro font black on dark grey text, incorrect rendering. FYI: Firefox 80 / macOS / OS X / Source Code Pro font black on dark grey text, incorrect rendering. Sep 17, 2020
@joshgoebel
Copy link
Member

Thanks for the info!

@joshgoebel joshgoebel added docs/website theme and removed enhancement An enhancement or new feature labels Sep 17, 2020
@joshgoebel joshgoebel pinned this issue Sep 21, 2020
@stevenjoezhang stevenjoezhang mentioned this issue Sep 22, 2020
Closed
@joshgoebel joshgoebel unpinned this issue Nov 13, 2020
@joshgoebel
Copy link
Member

Will auto-close this in 2021 since there is no action we can take... do they have any plans to fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs/website theme
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joshgoebel @kneufeld