Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(asciidoc) Section titles level 5 (i.e. using 6 "=" characters) #2868

Closed
ggrossetie opened this issue Nov 15, 2020 · 4 comments · Fixed by #2903
Closed

(asciidoc) Section titles level 5 (i.e. using 6 "=" characters) #2868

ggrossetie opened this issue Nov 15, 2020 · 4 comments · Fixed by #2903
Labels
bug good first issue Should be easier for first time contributors help welcome Could use help from community language
Milestone

Comments

@ggrossetie
Copy link
Contributor

Describe the issue

Section titles level 5 (i.e. using 6 "=" characters) are not recognized as section titles.

Which language seems to have the issue?

asciidoc

Sample Code to Reproduce

= Document Title (Level 0)

== Level 1 Section Title

=== Level 2 Section Title

==== Level 3 Section Title

===== Level 4 Section Title

====== Level 5 Section Title

== Another Level 1 Section Title

https://asciidoctor-docs.netlify.app/asciidoc/current/sections/titles-and-levels/#section-level-syntax

Expected behavior

====== Level 5 Section Title should be highlighted as a section title.

Additional context

For reference:

@ggrossetie ggrossetie added bug help welcome Could use help from community language labels Nov 15, 2020
@joshgoebel joshgoebel added the good first issue Should be easier for first time contributors label Nov 15, 2020
@joshgoebel
Copy link
Member

This one looks super easy, you want to try a PR? :-)

@ggrossetie
Copy link
Contributor Author

I will ask in the Asciidoctor Gitter channel, maybe someone will be interested in making a (first-time) contribution to Highlight.js.

@joshgoebel
Copy link
Member

If you get frustrated on the other come solve this, should be easy. :)

@ggrossetie
Copy link
Contributor Author

If you get frustrated on the other come solve this, should be easy. :)

Ah ah ah! I'm trying to keep my sanity but it's hard!
You can quickly lose your mind while working on regular expressions 🤪🤪🤪

I admire your bravery!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug good first issue Should be easier for first time contributors help welcome Could use help from community language
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants