Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

continue CSS Consistency #2937

Merged
merged 15 commits into from
Jan 29, 2021
Merged

continue CSS Consistency #2937

merged 15 commits into from
Jan 29, 2021

Conversation

joshgoebel
Copy link
Member

@joshgoebel joshgoebel commented Dec 24, 2020

Changes

Continues work towards CSS consistency across all our CSS grammars
that allow raw CSS (ie, they are supersets). Cleans up all grammars a lot.

Less is still a hot mess, but the other 3 are getting a lot cleaner.

Checklist

  • Added markup tests, or they don't apply here because...
  • Updated the changelog at CHANGES.md
  • Added myself to AUTHORS.txt, under Contributors

@joshgoebel joshgoebel changed the title WIP: continue CSS Consistency continue CSS Consistency Dec 26, 2020
@joshgoebel joshgoebel added enhancement An enhancement or new feature language labels Dec 26, 2020
@joshgoebel
Copy link
Member Author

Should be easy to review this one one commit at a time if the overall view is too messy. I tried to keep them clean.

src/languages/lib/css-shared.js Show resolved Hide resolved
src/languages/css.js Show resolved Hide resolved
Copy link
Collaborator

@egor-rogov egor-rogov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature language
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants