-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
continue CSS Consistency #2937
Merged
Merged
continue CSS Consistency #2937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshgoebel
force-pushed
the
css_stuffs
branch
from
December 25, 2020 16:36
f41cbb6
to
f1c7c33
Compare
Should be easy to review this one one commit at a time if the overall view is too messy. I tried to keep them clean. |
egor-rogov
reviewed
Jan 19, 2021
egor-rogov
approved these changes
Jan 20, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
joshgoebel
force-pushed
the
css_stuffs
branch
from
January 29, 2021 14:54
f17bec8
to
7919a46
Compare
joshgoebel
force-pushed
the
css_stuffs
branch
from
January 29, 2021 14:59
7919a46
to
98a509b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Continues work towards CSS consistency across all our CSS grammars
that allow raw CSS (ie, they are supersets). Cleans up all grammars a lot.
Less is still a hot mess, but the other 3 are getting a lot cleaner.
Checklist
CHANGES.md
AUTHORS.txt
, under Contributors