Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "jsonc" alias #4018

Closed
cpfeiffer opened this issue Mar 15, 2024 · 6 comments · Fixed by #4028
Closed

Add "jsonc" alias #4018

cpfeiffer opened this issue Mar 15, 2024 · 6 comments · Fixed by #4028
Labels
enhancement An enhancement or new feature good first issue Should be easier for first time contributors help welcome Could use help from community

Comments

@cpfeiffer
Copy link 

          @glen-84 Would you be happier if we added a "jsonc" alias?

Originally posted by @joshgoebel in #2016 (comment)

rouge and shiki support jsonc as identifier, so it would be nice to have this in highlightjs as well.

See
@joshgoebel joshgoebel added enhancement An enhancement or new feature help welcome Could use help from community good first issue Should be easier for first time contributors labels Mar 15, 2024
@joshgoebel
Copy link
Member

Sounds reasonable.

@BackupMiles
Copy link
Contributor

Hi! Can this issue be assigned to me?

@joshgoebel
Copy link
Member

Just make a PR - people aren't rushing in huge lines to complete these issues. :)

@BackupMiles
Copy link
Contributor

Sure will! Thank you :D

@BackupMiles
Copy link
Contributor

BackupMiles commented Mar 28, 2024 •
edited

Quick question: would a "jsonc" alias suffice to the json.js returned object?
From what I gather the json language defined inside hljs already accepts comments

@joshgoebel
Copy link
Member

Yes we just need to add the alias.

@BackupMiles BackupMiles mentioned this issue Mar 29, 2024
Merged
2 tasks
@harmathy harmathy mentioned this issue Apr 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement An enhancement or new feature good first issue Should be easier for first time contributors help welcome Could use help from community
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add jsonc alias to json BackupMiles/highlight.js
3 participants
@joshgoebel @cpfeiffer @BackupMiles