Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strings and keywords in .meta look ugly #967

Closed
isagalaev opened this issue Oct 27, 2015 · 3 comments
Closed

Strings and keywords in .meta look ugly #967

isagalaev opened this issue Oct 27, 2015 · 3 comments
Labels
Milestone

Comments

@isagalaev
Copy link
Member

After class names unification there's one problem that stands out like a sore eye: keywords and strings within preprocessor directives look ugly because .meta usually has a very distinctive color that doesn't play well with .string and .keywords showing up within it:

meta-keywords-strings

Two possible solutions:

  • Bless and document usage of selector combinations like .hljs-meta .hljs-string and .hljs-meta * to reset colors. This is hacky and easy to forget.
  • Define separate .hljs-meta-string and .hljs-meta-keyword.
@Sannis
Copy link
Collaborator

Sannis commented Oct 30, 2015

This is hacky and easy to forget.

We already have selectors for sub-languages in some themes, so it does not look ugly for me.

@Sannis Sannis added the bug label Oct 30, 2015
@Sannis Sannis added this to the 9.0 milestone Oct 30, 2015
@isagalaev
Copy link
Member Author

We already have selectors for sub-languages in some themes, so it does not look ugly for me.

No, we don't anymore :-) That was the whole point.

@isagalaev
Copy link
Member Author

Fixed in f7f38f7. Also related:

  • 8616294 for the same problem with built-in names in lisps
  • 9f31cd0 for built-ins in templates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants