Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VMLRendererExtension isIE8 returns false for IE8 running in browser compatibility mode #2890

Closed
oriondean opened this issue Apr 8, 2014 · 2 comments

Comments

@oriondean
Copy link

VMLRendererExtension uses the following condition to determine whether a browser is IE8 or not: isIE8: userAgent.indexOf('MSIE 8.0') > -1

As a result, when IE8 is running in browser compatibility mode its user agent contains MSIE 7.0 rather than MSIE 8.0.

This failing condition causes issues such as plot lines not appearing on the chart when hovering.

An easy solution would be to replace the userAgent check with the docMode8 boolean that is based on the documentMode of the browser.

@TorsteinHonsi
Copy link
Collaborator

Thanks for reporting. It seems that isIE8 is used only in one place, the prepVML method. If we change this, we need to fully understand what's happening, as we have already found a very delicate balance between the abundant VML rendering bugs. Perhaps the isIE8 check was intentional. I can't see any issues with this chart - http://jsfiddle.net/highcharts/jkwFP/show - can you show us a chart that fails?

@jon-a-nygaard
Copy link
Contributor

Closing this issue due to: We are not able to reproduce the issue, and it is pending reply.
Should anyone have further information on this issue, please add a comment and reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants