Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sum in waterfall chart is not calculated correctly #4954

Closed
iddofontijn opened this issue Jan 25, 2016 · 2 comments
Closed

sum in waterfall chart is not calculated correctly #4954

iddofontijn opened this issue Jan 25, 2016 · 2 comments
Assignees
@jon-a-nygaard
Labels
Type: Bug

Comments

@iddofontijn
Copy link

See this jsfiddle.

Somehow 0.0000000000002 is added to the sum. I've also seen a case where this amount is extracted from the sum.
@pawelfus
Copy link
Contributor

This is issue with floating point numbers in JS, for example run in the console:

 0.4 - 0.3

It will return:

0.10000000000000003

@TorsteinHonsi
Copy link
Collaborator

@jon-a-nygaard We have an internal function called correctFloat for this purpose. Check out how we have used it in the past, then apply it for example on the waterfall sum. Check out intermediateSum also.

jon-a-nygaard added a commit that referenced this issue Jan 27, 2016
@jon-a-nygaard
Fixed #4954, corrected floating values with isSum and isIntermediateS…
d1d1ccd 
…um in Waterfall series.
sigrunnu added a commit that referenced this issue Jun 26, 2019
@sigrunnu
Tests: Moved issue test #4954 to unit-tests.
d323ee0
@sigrunnu sigrunnu mentioned this issue Jun 26, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jon-a-nygaard jon-a-nygaard

Labels
Type: Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@TorsteinHonsi @pawelfus @jon-a-nygaard @iddofontijn