Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

highstock event call e.point.update throw exceptions #8023

Closed
xcqwan opened this issue Mar 15, 2018 · 7 comments
Closed

highstock event call e.point.update throw exceptions #8023

xcqwan opened this issue Mar 15, 2018 · 7 comments

Comments

@xcqwan
Copy link

xcqwan commented Mar 15, 2018

Expected behaviour

click column call e.point.update() will throw exception when render by highstock

Actual behaviour

http://jsfiddle.net/yzkgoxcb/3/

Live demo with steps to reproduce

Product version

Affected browser(s)

@pawelfus
Copy link
Contributor

Hi @xcqwan

Thank you for reporting this issue. It looks fine when we update point with any options, even empty object: http://jsfiddle.net/BlackLabel/yzkgoxcb/10/ - do you want to update point without any options?

@xcqwan
Copy link
Author

xcqwan commented Mar 16, 2018

this will let navigator render error
http://jsfiddle.net/yzkgoxcb/14/

@pawelfus
Copy link
Contributor

Thank you! You are right, something is wrong there.

Simplified demo: http://jsfiddle.net/BlackLabel/yzkgoxcb/30/

Internal notes:

@pawelfus pawelfus self-assigned this Mar 16, 2018
@pawelfus
Copy link
Contributor

Internal note:
We have two issues here:

  • updating point (as simply y-value) without options cause error in Highstock
  • updating point when using Highcharts.chart constructor with enabled navigator cause wrong extremes (xAxis.overscroll is not defined for this constructor -> max is calculated as NaN)

pawelfus added a commit that referenced this issue Mar 16, 2018
@pawelfus
Copy link
Contributor

The commit above fixes both issues.

Workaround:
Set xAxis.overscroll = 0 in options, demo: http://jsfiddle.net/BlackLabel/yzkgoxcb/45/

Internal note:
If we find more bugs like this, where overscroll is not defined with Highcharts.chart constructor, we could consider setting this options in Axis.js file, instead of Navigator.js.

@xcqwan
Copy link
Author

xcqwan commented Mar 19, 2018

@pawelfus Thanks, is work for me, but overscroll don't defined on doc

@pawelfus
Copy link
Contributor

Hi @xcqwan

That's correct, overscroll is not defined in Highcharts docs, but you use Highstock where we have it's definition (similar to Navigator, Scrollbar etc.): https://api.highcharts.com/highstock/xAxis.overscroll It's set by default to 0 for stockChart(), but not defined for chart().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants