Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a rust-toolchain.toml #1

Closed

Conversation

mistydemeo
Copy link

I normally have rustup set to use the latest stable release, so having this was helpful for me to give rustup a hint that it should switch to nightly for this project.

@hikari-no-yume
Copy link
Owner

Wait, this needs nightly? I thought I was using stable, but maybe I was only doing that for the native builds for some reason. What problem did you hit?

@mistydemeo
Copy link
Author

There's two build errors on stable:

error[E0658]: use of unstable library feature 'int_roundings'
   --> src/wasm_ffi.rs:193:65
    |
193 |         last_event_time + ((ticks_per_quarter_note * 120) / 60).div_ceil(1000 / 50)
    |                                                                 ^^^^^^^^
    |
    = note: see issue #88581 <https://github.com/rust-lang/rust/issues/88581> for more information
error[E0277]: the trait bound `std::io::Empty: std::io::Write` is not satisfied
   --> src/wasm_ffi.rs:221:9
    |
218 |     crate::midi::write_midi(
    |     ----------------------- required by a bound introduced by this call
...
221 |         &mut std::io::empty(),
    |         ^^^^^^^^^^^^^^^^^^^^^ the trait `std::io::Write` is not implemented for `std::io::Empty`
    |
note: required by a bound in `write_midi`
   --> src/midi.rs:426:8
    |
419 | pub fn write_midi<F, L>(
    |        ---------- required by a bound in this function
...
426 |     L: Write,
    |        ^^^^^ required by this bound in `write_midi`

@mistydemeo
Copy link
Author

Hm, no, it actually looks like I was just on a slightly outdated stable. I was on 1.72.1, updating to 1.74.1 fixes it.

@mistydemeo mistydemeo closed this Dec 10, 2023
@mistydemeo mistydemeo deleted the rust_toolchain_toml branch December 10, 2023 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants