Add message_link/channel_link to MessageReference #1877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beagold
reviewed
Apr 12, 2024
|
Test failures are unrelated and will be fixed by #1881. I will later merge that over this pull request and I believe it should be good to merge. Thanks again! |
Le0Developer
force-pushed
the
feat/messageref-makelink
branch
from
0c3e59d
to
c7d63e4
Compare
Co-authored-by: beagold <86345081+beagold@users.noreply.github.com> Signed-off-by: Leo Developer <LeoDeveloper@protonmail.com>
Co-authored-by: beagold <86345081+beagold@users.noreply.github.com> Signed-off-by: Leo Developer <LeoDeveloper@protonmail.com>
Le0Developer
force-pushed
the
feat/messageref-makelink
branch
from
c7d63e4
to
9bf78ad
Compare
beagold
previously approved these changes
Apr 14, 2024
|
@Le0Developer running |
beagold
approved these changes
Apr 14, 2024
Le0Developer
changed the title
FasterSpeeding
approved these changes
Apr 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds the
make_link()function of Message to MessageReference.Checklist
noxand all the pipelines have passed. (my setup is borked)