Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hikka Modules Bugs #43

Closed
1 task done
anon97945 opened this issue Jun 7, 2022 · 5 comments
Closed
1 task done

Hikka Modules Bugs #43

anon97945 opened this issue Jun 7, 2022 · 5 comments
Assignees
Labels
bug Something isn't working as intended

Comments

@anon97945
Copy link

anon97945 commented Jun 7, 2022

  • silent_tags.py | blocked user list won't refresh/doesn't work. I use silent_blocked true, but it still appeases in the logchat.

should be :
if self.config["ignore_blocked"] or self.config["silent_blocked"]:

instead of:
if self.config["ignore_blocked"]

https://github.com/hikariatama/ftg/blob/af63c0c9c2459adf019465a9e5fa2c86747cbf08/silent_tags.py#L167

IMG_20220607_210056_816

@anon97945 anon97945 added bug Something isn't working as intended module labels Jun 7, 2022
@anon97945
Copy link
Author

anon97945 commented Jun 7, 2022

  • inline_spotify.py | getting following error:
🚫 [ERROR] hikka.modules.inline_spotify: BRUH
Traceback (most recent call last):
  File "https://mods.hikariatama.ru/inline_spotify.py", line 157, in inline_iter
    any(uid == i.unit_uid for i in self._active_forms)
  File "https://mods.hikariatama.ru/inline_spotify.py", line 157, in <genexpr>
    any(uid == i.unit_uid for i in self._active_forms)
AttributeError: 'InlineMessage' object has no attribute 'unit_uid'

@anon97945
Copy link
Author

anon97945 commented Jun 7, 2022

  • activists | it doesn't count self in groups.

@hikariatama
Copy link
Owner

activists | it doesn't count self in groups.

Not a bug. It's intended behavior to not count admins. I'll make a config value to add ability to change this

@hikariatama
Copy link
Owner

hikariatama commented Jun 11, 2022

  • silent_tags.py | properly handle messages from channels

@hikariatama hikariatama changed the title Hikka Modules Bug List Hikka Modules Bugs Jun 23, 2022
@hikariatama hikariatama self-assigned this Jun 23, 2022
@anon97945
Copy link
Author

anon97945 commented Jun 27, 2022

  • silent_tags.py | properly handle messages from channels

from telethon.tl.types import Message, Channel

https://github.com/hikariatama/ftg/blob/master/silent_tags.py#L22

        if (
            (
                self.config["whitelist"]
                and message.sender_id not in (self.config["silent_users"] or [])
                or not self.config["whitelist"]
                and message.sender_id in (self.config["silent_users"] or [])
            )
            or self.config["silent_blocked"]
            and message.sender.id in self._blocked
            or (
                self.config["whitelist"]
                and utils.get_chat_id(message)
                not in (self.config["silent_chats"] or [])
                or not self.config["whitelist"]
                and utils.get_chat_id(message) in (self.config["silent_chats"] or [])
            )
        ):
            return
        if not (isinstance(user, Channel)):
            if self.config["silent_bots"] and message.sender.bot:
                return

https://github.com/hikariatama/ftg/blob/master/silent_tags.py#L270-L289

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as intended
Projects
None yet
Development

No branches or pull requests

2 participants