Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pyx file again #6

Closed
hildensia opened this issue Jun 19, 2015 · 5 comments
Closed

Add pyx file again #6

hildensia opened this issue Jun 19, 2015 · 5 comments
Assignees

Comments

@hildensia
Copy link
Owner

Was removed during a PR. Is there a good way to keep cython and python in sync. I'm not sure if I prefer one over the other (python is better for debugging, cython is faster).

@mathDR
Copy link
Collaborator

mathDR commented Jun 19, 2015

I haven't found a good way to keep them in sync. I think right now the examples are plenty fast. In any case, I added the original cy_offline.pyx and cy_offline_changepoint_detection.py files back to the repository.

@mathDR
Copy link
Collaborator

mathDR commented Jun 19, 2015

Also, its not clear that the speedup gains are optimized. If the new multivariate likelihoods are to by cythonized, then outer(), slogdet(), multigammaln() and gammaln() should all be cythonized. Thoughts?

@hildensia
Copy link
Owner Author

It is probably not really worthwhile using cython right now. I just tried it for an experiment, but it wasn't really speeding things up a lot. For my part it can be removed.

@mathDR
Copy link
Collaborator

mathDR commented Jul 24, 2015

Should we close this issue then?

@hildensia
Copy link
Owner Author

Yepp. You're right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants