Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved sac version #1042

Closed
xiao-hua-sheng opened this issue Nov 18, 2020 · 2 comments
Closed

Improved sac version #1042

xiao-hua-sheng opened this issue Nov 18, 2020 · 2 comments
Labels
question Further information is requested

Comments

@xiao-hua-sheng
Copy link

xiao-hua-sheng commented Nov 18, 2020 •
edited
Loading

Is sac version 1.0 only?Has version 2.0 of the V function been canceled.
@araffin araffin added the question Further information is requested label Nov 18, 2020
@araffin
Copy link
Collaborator

araffin commented Nov 18, 2020

Is sac version 1.0 only?Has version 2.0 of the V function been canceled.

What do you mean?
Yes, we are using the variation with the V value.
If you want the one with two Q-values targets, you can take a look at Stable-Baselines3.
In practice, both implementations have similar performances: DLR-RM/stable-baselines3#48

@xiao-hua-sheng
Copy link
Author

okay, thank you

@araffin araffin closed this as completed Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@araffin @xiao-hua-sheng