Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Windows file paths including %5C instead of / #44

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

gronke
Copy link
Collaborator

@gronke gronke commented Dec 16, 2015

fixes #39

@gronke
Copy link
Collaborator Author

gronke commented Dec 16, 2015

@bboydflo can you help reproducing this bug? Running the tests on Windows 10 does not produce the error you described. I'd like to add more tests that match with your scenario to ensure the fix ist sustainable.

@bboydflo
Copy link

@gronke I am running on windows 8. Yesterday I updated this package and I noticed I get the "%5C" instead of "/". It seems that this only happens for nested file paths. First "/" on a line gets output correctly but nested paths get "%5C" instead (Example: dist/fonts%5Cfontawesome-webfont.eot)

@gronke
Copy link
Collaborator Author

gronke commented Dec 16, 2015

Can you test this branch on your machine? Still see no difference on Windows 10. Can you checkout this branch and run it locally so that we see this test is producing the issue there?

@bboydflo
Copy link

@gronke I tested this branch and it worked.

@gronke
Copy link
Collaborator Author

gronke commented Dec 16, 2015

Meh.. so the next step will be to make it fail. Would you mind modifying the test case until it reproduces the issue?

@gronke
Copy link
Collaborator Author

gronke commented Jan 31, 2016

@bboydflo any update on how we can reproduce the issue in a unit test?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

%5C instead of / when generating a manifest
2 participants