Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intro Slider #24

Closed
himanshusharma89 opened this issue Oct 3, 2020 · 31 comments · Fixed by #66
Closed

Intro Slider #24

himanshusharma89 opened this issue Oct 3, 2020 · 31 comments · Fixed by #66
Assignees
Labels

Comments

@himanshusharma89
Copy link
Owner

A full-screen intro slider when user freshly installs the app before registration.

@hutomosaktikartiko
Copy link

A full-screen intro slider when user freshly installs the app before registration.

do you already have a design that will be applied to the code?

@himanshusharma89
Copy link
Owner Author

@hutomosaktikartiko I don't have a particular design, you can follow up the current UI and create the intro slider

@himanshusharma89 himanshusharma89 added the good first issue Good for newcomers label Oct 5, 2020
@himanshusharma89
Copy link
Owner Author

Hi @Dhruv-Sachdev1313, you can create PageView with 3 Pages for intro slider with the help of smooth page indicator when the user freshly installs the app.

@Dhruv-Sachdev1313
Copy link

heyy @himanshusharma89 , Thanks for tagging me in this issue. Anything specific you want in intro sliders?

@himanshusharma89
Copy link
Owner Author

@Dhruv-Sachdev1313 Just create a page view slider, with appropriate assets for the App with current UI in mind. you can refer to smaranjitghose/girlscript_app#270 (comment)

@Dhruv-Sachdev1313
Copy link

@himanshusharma89 ohkayy . I am on it . please assign it to me

@Dhruv-Sachdev1313
Copy link

heyy @himanshusharma89 I know this is a very naive question but I couldn't make your code run in my machine. I guess it is the lowercase issue of the name of the project. Can you please guide ?
Screenshot 2020-10-06 at 1 48 47 AM

@himanshusharma89
Copy link
Owner Author

@Dhruv-Sachdev1313 No need to create a flutter project, pull the latest from the remote. Do the pub get in pubspec.yaml and restart vs code.

@Dhruv-Sachdev1313
Copy link

heyy @himanshusharma89 it worked. I just have a question, Is firebase setup for IOS , I mean have you added the googleService.info.plist file in runner directory? because I can't see any

@himanshusharma89
Copy link
Owner Author

Hi @Dhruv-Sachdev1313, I don't have Xcode so I couldn't integrate it for iOS. Share me your email, I'll add you to the console.

@Dhruv-Sachdev1313
Copy link

@himanshusharma89 my email id is dhruvhsachdev@gmail.com, or else I could get an android phone to test this app. anything is fine for me.

@himanshusharma89
Copy link
Owner Author

@Dhruv-Sachdev1313 Added to console. And I think we should go for iOS integration. Create an issue for iOS integration, I'll assign it to you.

@himanshusharma89
Copy link
Owner Author

@Dhruv-Sachdev1313 Any update?

@Dhruv-Sachdev1313
Copy link

@himanshusharma89 Yess , I wanted to add gif like image, so I am trying to figure out how could a record a screen video in my simulator and convert it to gif, and also I am working on completing the firebase for iOS setup, just give me a little time if its ok for you ?

@himanshusharma89
Copy link
Owner Author

Sure @Dhruv-Sachdev1313, take your time and if you need gifs, checkout: https://lottiefiles.com/

@Dhruv-Sachdev1313
Copy link

@himanshusharma89 Hey, is it ok if I make PR till this weekend? actually I am really occupied with college stuff. Am I making the project delay?

@himanshusharma89
Copy link
Owner Author

@Dhruv-Sachdev1313 It is okay, take your time.

@Dhruv-Sachdev1313
Copy link

Hey @himanshusharma89 . I am facing a little trouble with choosing the colour part, Could you please give me some reviews and suggestions, as you can say that I am not that good when it comes to choosing colour combinations😅. By the way in the last screenshot for dark mode that image is a GIF for dark mode, I also have uploaded that gif at the last .

Simulator Screen Shot - iPhone 11 Pro Max - 2020-10-16 at 19 52 13
Simulator Screen Shot - iPhone 11 Pro Max - 2020-10-16 at 19 52 16
Simulator Screen Shot - iPhone 11 Pro Max - 2020-10-16 at 19 52 25

darkmode

@himanshusharma89
Copy link
Owner Author

himanshusharma89 commented Oct 16, 2020

@Dhruv-Sachdev1313 Use rounded icons and normal text Alignment. And about the colour, I am not so good at choosing the colour, you can refer to https://coolors.co/ to generate a palette

@Dhruv-Sachdev1313
Copy link

@himanshusharma89 Thanks for the colour website, but I couldn't understand exactly what do you mean by the rounded icons and normal text alignment, can you please explain a little more about that

@himanshusharma89
Copy link
Owner Author

@Dhruv-Sachdev1313 In the beta branch you have updated icons check them and don't make the text italic. This was what I meant.

@Dhruv-Sachdev1313
Copy link

Dhruv-Sachdev1313 commented Oct 18, 2020

@himanshusharma89 By beta branch you mean the beta channel of flutter sdk ???

@himanshusharma89
Copy link
Owner Author

Yeah @Dhruv-Sachdev1313

@Dhruv-Sachdev1313
Copy link

@himanshusharma89 . Hey I was searching about the iOS SDK issue in firebase that we faced, I saw it on Youtube, that guy faced the same issue. I guess that it is a bug from firebase side, because as you saw even that day that our app was communicating with firebase servers , but it did not update the status in console.

@himanshusharma89
Copy link
Owner Author

@Dhruv-Sachdev1313 Some times Android also face this issue, you can try it again, it should work and what about the intro slider? Any update?

@Dhruv-Sachdev1313
Copy link

Dhruv-Sachdev1313 commented Oct 28, 2020

@himanshusharma89 Ohkaay, i will try again, About the intro slider, I am still not convinced full by how it looks, just a question as I have shared the screenshot before, is there anything on content side to add or delete?

@himanshusharma89
Copy link
Owner Author

@Dhruv-Sachdev1313 You can add some illustrations/vectors in the intro slides, I'll add the content later. And pull the code before working on it.

@Dhruv-Sachdev1313
Copy link

hey @himanshusharma89 . Sorry for the delay in this issue, but I am facing a problem due to which this app is not running in my simulator. This Issue is similar to this one firebase/firebase-ios-sdk#6462
I have added the screenshot of the error, I have tried updating the pods several times , but it didn't work.
Screenshot 2020-11-11 at 10 46 01 PM

@himanshusharma89
Copy link
Owner Author

Hey @Dhruv-Sachdev1313, sorry for the late response, are you still facing the issue?

@Saransh-cpp
Copy link
Contributor

Hey, if the assignee is not able to make it, can I work on this issue? I had some doubts, there is no registration screen so how will the showing intro sliders only once thing work? Should I use SharedPreferences to store the user's data (that if he has already seen the screens or not) locally?

@himanshusharma89
Copy link
Owner Author

Yeah @Saransh-cpp, SahredPreferences will be used to store the data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants