Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IsNavigable Uncaught Type errors #47

Open
stratasy opened this issue Aug 18, 2021 · 4 comments
Open

IsNavigable Uncaught Type errors #47

stratasy opened this issue Aug 18, 2021 · 4 comments
Labels
Status: Investigation Issue is being investigated more Status: More info needed More information is required before this can be worked on

Comments

@stratasy
Copy link

stratasy commented Aug 18, 2021

When copying and pasting the code for the navigable bar chart:

<script>
  import Chart from "svelte-frappe-charts";

  let data = {
    labels: [ "Sun", "Mon", "Tue", "Wed", "Thu", "Fri", "Sat", "Sun", "Mon", "Tue", "Wed", "Thu", "Fri", "Sat", "Sun", "Mon" ],
    datasets: [
      { values: [ 300, 250, 720, 560, 370, 610, 690, 410, 370, 480, 620, 260, 170, 510, 630, 710 ] },
    ],
  };

  const onDataSelect = (event) => {
    console.log("Data select event fired!", event);
    selected = event;
  };
  let selected;
</script>

<Chart {data} on:data-select={onDataSelect} isNavigable type="bar" />

I am getting these errors:
Uncaught TypeError: Cannot read property 'nodeName' of undefined and
Uncaught TypeError: Cannot read property 'parentNode' of undefined

image

@stratasy
Copy link
Author

stratasy commented Aug 19, 2021

Just an update: Rolling back to 1.8 fixes this issue, so it might have something to do with the PR @bry-an put out. Obviously rolling this back reintroduces the issue described here: #44

@himynameisdave himynameisdave added Status: Investigation Issue is being investigated more Status: More info needed More information is required before this can be worked on labels Sep 30, 2021
@marciox25
Copy link

marciox25 commented May 23, 2022

Any followup on this? Im also able to replicate by simply copying the code mentioned in the issue in an component. Rolling back to 1.8 did not fixed it for me

@kuutsav
Copy link

kuutsav commented Aug 29, 2022

Hi, any update? I'm facing the same issue

@Gildedter
Copy link

Facing a similar issue
image
image

removing the isNavigable property removes the error (with just the event assigned), but without that property, no event would fire, I just pasted the Chart Navigation example on the ReadMe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Investigation Issue is being investigated more Status: More info needed More information is required before this can be worked on
Projects
None yet
Development

No branches or pull requests

5 participants