Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript definitions #54

Open
DoodlesEpic opened this issue Jun 14, 2022 · 6 comments
Open

TypeScript definitions #54

DoodlesEpic opened this issue Jun 14, 2022 · 6 comments
Labels
Status: In Progress Being worked on Type: Feature Adds a new feature

Comments

@DoodlesEpic
Copy link

Currently, the package does not provide TypeScript definitions. It would be nice if the package provided TypeScript definitions to avoid this kind of error:

Error: Could not find a declaration file for module 'svelte-frappe-charts'. '/node_modules/svelte-frappe-charts/lib/index.js' implicitly has an 'any' type.
  Try `npm i --save-dev @types/svelte-frappe-charts` if it exists or add a new declaration (.d.ts) file containing `declare module 'svelte-frappe-charts';` (ts)

This should be pretty simple to do since the @types/frappe-gantt package is already available.

@youknowedo
Copy link

Made a PR ( #57 ) fingers crossed they review it 🤞🏾

@himynameisdave himynameisdave added Status: In Progress Being worked on Type: Feature Adds a new feature labels Sep 16, 2022
@himynameisdave
Copy link
Owner

It's been reviewed now, so once the questions/code comments have been addressed and it's rebased/merged with main I am happy to merge and release this!

@pieterdhondt
Copy link

Any update on this?

@Gbox4
Copy link

Gbox4 commented Apr 27, 2023

Please release types! Easy feature to add and is going to 10x the accessibility of this great library!

@d3F0g
Copy link

d3F0g commented Jun 29, 2023

Are the types updated?

@Nacir1i
Copy link

Nacir1i commented Aug 22, 2023

any updates in this issue ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: In Progress Being worked on Type: Feature Adds a new feature
Projects
None yet
Development

No branches or pull requests

7 participants