Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ip4: Refactored code in cidr.hpp #1661

Merged
merged 1 commit into from Feb 20, 2018
Merged

ip4: Refactored code in cidr.hpp #1661

merged 1 commit into from Feb 20, 2018

Conversation

RicoAntonioFelix
Copy link
Contributor

No description provided.

AndreasAakesson
AndreasAakesson approved these changes Feb 9, 2018
View reviewed changes
Copy link
Contributor

@AndreasAakesson AndreasAakesson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me.
One question; what will be a case when constexpr function is used/useful?

@RicoAntonioFelix
Copy link
Contributor Author

@AndreasAakesson Since you've initially marked that the object can be constructed within a compile time context, it made sense to also have the getters be used in such a context also.

@alfreb alfreb merged commit 4ff8cf4 into includeos:dev Feb 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndreasAakesson AndreasAakesson AndreasAakesson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@RicoAntonioFelix @AndreasAakesson @alfreb