Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

catalog_info_ returning the errors for radius/mass_min/max instead of the min/max values #100

Closed
PS-OnGit opened this issue Feb 24, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@PS-OnGit
Copy link

Dear TLS team,
I noticed, that the catalog_info_TIC function returns the error values for the radius_min,radius_max,mass_min and mass_max.

This issue can be easily fixed, by changing lines 77 to 81 in catalog.py as follows:

radius_max = radius + result[0][71]
radius_min = radius - result[0][71]
mass = result[0][72]
mass_max = mass + result[0][73]
mass_min = mass - result[0][73]

The same is true for the catalog_info_EPIC and KIC, while there the _max and _min correspond to the asymmetric errors.
Hence lines 27-31 and 56-60 should be:

radius_max = radius + result[0][3]
radius_min = radius - result[0][4]
mass = result[0][5]
mass_max = mass + result[0][6]
mass_min = mass - result[0][7]

I hope, that i don't misunderstood these queries.

Kind regards,
Paul Schwarz

@PS-OnGit PS-OnGit added the bug Something isn't working label Feb 24, 2022
@PS-OnGit
Copy link
Author

I just noticed my mistake, and have to correct my report.

The return values work as intended and as described in the documentation.
but the naming is misleading.
Please excuse my mistake!

Kind regards,
Paul Schwarz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant