Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Period Grid Limits #80

Closed
MXK606 opened this issue Mar 6, 2020 · 3 comments
Closed

Period Grid Limits #80

MXK606 opened this issue Mar 6, 2020 · 3 comments
Labels
help wanted Extra attention is needed

Comments

@MXK606
Copy link

MXK606 commented Mar 6, 2020

Hi, I am trying to run TLS with a certain period min. and max. limit but it resorts to using the default values instead.

model = tls(time, flux)
results = model.power(period_min=0.1, period_max=60.0)
results
Transit Least Squares TLS 1.0.24 (21 November 2019)
Creating model cache for 29 durations
Searching 14400 data points, 2747 periods from 0.601 to 14.833 days
Using all 8 CPU threads

I'm not sure what I'm doing wrong here, please could you help me out.

@MXK606 MXK606 added the bug Something isn't working label Mar 6, 2020
@hippke
Copy link
Owner

hippke commented Mar 9, 2020

The limitation comes from physics. Shorter periods are unphysical for your chosen mass and radius (the defaults). You can adjust these for shorter periods. On the long side, the default is to have 3 transits. You can set n_transits_min=2 to search for (slightly) longer transits.

@MXK606
Copy link
Author

MXK606 commented Mar 9, 2020

Ah, right. That makes sense. The reason why I'm setting the upper limit on period so high is because I'm running TLS on simulated light-curves with injected transits of long period planets. So, even if I set n_transits_min=1, it will only search for periods equal to the time series duration.

Is it possible to make TLS search for periods greater than the observation time span?

@hippke hippke added help wanted Extra attention is needed and removed bug Something isn't working labels Mar 10, 2020
@hippke
Copy link
Owner

hippke commented Mar 10, 2020

With n_transits_min=1 you already have activated the search for single transits. If one is found, the estimated period will be the duration of your light curve. Of course, it can be longer in reality. But there is no way (and no need) to adjust the search beyond single transits.

@hippke hippke closed this as completed Mar 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants