Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kotlin daily builds #10

Closed
pascalgrimaud opened this issue Jun 14, 2019 · 8 comments
Closed

Kotlin daily builds #10

pascalgrimaud opened this issue Jun 14, 2019 · 8 comments

Comments

@pascalgrimaud
Copy link
Member

Following this jhipster/jhipster-kotlin#138 (comment)

@Hawkurane
Copy link
Collaborator

I can look into this later.
Do we create a new pipeline we 10 jobs for Kotlin blueprints or do we regenerate the projects in each jobs but with Kotlin blueprints?
The former looks better if we add more blueprints tests later (looking at you vuejs...).

WDYT @pascalgrimaud

@pascalgrimaud
Copy link
Member Author

new dedicated pipeline with Kotlin, similar to the config with 'official' or 'official openjdk8' pipelines

With kotlin, you can use the same app/config (.yo-rc.json)

@Hawkurane
Copy link
Collaborator

It seems they have their own pipelines files for ci-cd that we can reuse (or supplement) for daily builds
https://github.com/jhipster/jhipster-kotlin/blob/master/azure-pipelines.yml
and scripts that i'm probably going to copy-pasta

@Hawkurane
Copy link
Collaborator

pinging @pvliss to ask what kind of config you would like to test.
Since your ci-cd pipeline is almost identical to the Official/OpenJDK8 one, I think implementing new and heavier configs are more interesting there but as I don't use the Kotlin blueprint, I don't know what kind of configs you are looking out for there.

@pvliss
Copy link
Contributor

pvliss commented Jul 3, 2019

Thanks for looking into this @Hawkurane. Well, the pipeline is indeed identical with the exception of one or two samples to test some extra configurations as there is currently no daily build. In fact, the KHipster blueprint supports the exact same features as the Java main generator. We can re-use all the existing samples(.yo-rc.json) but not sure about the pipelines. Ideally we could do the same but not sure if that is doable and maintainable(see also below). If not, then most interesting configurations would be the ones that alternate server side options. Maybe @sendilkumarn also has some extra thoughts regarding this?

I think I asked @pascalgrimaud before but would it be possible to have a separate repo for khipster daily builds in order to have all the pipelines of interest(instead of just 1-2) and re-use all samples(yo-rc.json) from this repo? Are there any limitations in Azure or do you think it would be very hard to maintain?

@sendilkumarn
Copy link
Member

That is a very valid point @pvliss

AFAICT, it would be great if we have separate repos for this. Because it will not be an overhead for anyone maintaining it. But if there are limitations, then we have to think about it.

@Hawkurane
Copy link
Collaborator

As far as I remember, each azure organization gets 10 parallel agents that can work at the same time. This means we can make another organization (e.g. khipster-daily-builds) which would be basically the fork from this repo and just changing the scripts to make sure the khipster blueprint is used.

@pascalgrimaud should be the one making the org imo if there should ever be a new azure organization/account

@pascalgrimaud
Copy link
Member Author

Opened for too long, let's close this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants