Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Swift support #20

Closed
vincent-psarga opened this issue Jan 29, 2016 · 7 comments
Closed

Add Swift support #20

vincent-psarga opened this issue Jan 29, 2016 · 7 comments

Comments

@vincent-psarga
Copy link
Contributor

No description provided.

@wills-dtb
Copy link

wills-dtb commented Nov 2, 2018

Hey @vincent-psarga, is this still in the pipeline and if so, is there an ETA on it?

@tvial-tagheuer
Copy link

It seems there's a PR here: #134

@vincent-psarga
Copy link
Contributor Author

yes indeed, the main problem with this PR right now is that I've been unable to make a proper hps-swift example to validate the generated code.

For all languages/framework supported by hiptest-publisher, we have our own implementation of the coffee machine sample (generally named hps-<language>-<framework>).

@tvial-tagheuer
Copy link

Maybe @bangroot can help on this? It will really help the community.

@bangroot
Copy link
Contributor

Oh, I didn’t realize that was a need. I’ll see what we can do. Might be a bit :/.

@vincent-psarga
Copy link
Contributor Author

I merged your PR anyway, it should not have waited that long, sorry about that.

Maybe we should have some explanations about that in the contributing MD file. But so far, when people contributed to other languages, it was pretty straightforward to get an example up and running, so I did not consider asking contributors to also add the hps-.

Once again, sorry for taking too long to get this PR merged. I'll try to do a release of the publisher asap :)

@vincent-psarga
Copy link
Contributor Author

I close it now since 1.30.0 includes the Swift support. Thanks again @bangroot for your PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants