Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change columns and rows to 1-based #10

Merged
merged 1 commit into from Jun 27, 2022
Merged

Conversation

kitagry
Copy link
Contributor

@kitagry kitagry commented Jun 27, 2022

Most of linters use 1-based value for row and col. But, tree-sitter use 0-based rows and cols.

https://docs.rs/tree-sitter/latest/tree_sitter/struct.Point.html

@codecov-commenter
Copy link

Codecov Report

Merging #10 (637724a) into main (e4db329) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #10   +/-   ##
=======================================
  Coverage   52.54%   52.54%           
=======================================
  Files           1        1           
  Lines         177      177           
=======================================
  Hits           93       93           
  Misses         84       84           
Impacted Files Coverage Δ
src/main.rs 52.54% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4db329...637724a. Read the comment docs.

@hirosassa
Copy link
Owner

LGTM!

@hirosassa hirosassa merged commit 468b8d9 into hirosassa:main Jun 27, 2022
@kitagry kitagry deleted the fix-columns branch June 27, 2022 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants