Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support target and empty output #30

Merged
merged 2 commits into from Nov 26, 2022
Merged

support target and empty output #30

merged 2 commits into from Nov 26, 2022

Conversation

hirosassa
Copy link
Owner

In this PR, I implemented followings:

  • target variable support which adds target variable on comment title.
  • no changes output which display no changes explicitly.

If you run ksnotify --target sample then we get following output:


Plan result (sample)

CI link

  • updated
    • apps.v1.Deployment.test.test-app
Details (Click me)

apps.v1.Deployment.jasmine.test-app

 @@ -5,7 +5,6 @@
     deployment.kubernetes.io/revision: "3"
+  labels:
+    app: test-app
   name: test-app
   namespace: test
 spec:
@@ -27,7 +26,6 @@
       creationTimestamp: null
       labels:
         app: test-app
-        skaffold.dev/run-id: 1234
     spec:
       containers:
       - args:

If you run ksnotify without any change in k8s configuration then we get following output:


Plan result (sample)

CI link

No changes. Kubernetes configurations are up-to-date.

@codecov-commenter
Copy link

codecov-commenter commented Nov 26, 2022

Codecov Report

Merging #30 (4e974ac) into main (b8c5e5b) will increase coverage by 4.78%.
The diff coverage is 79.09%.

@@            Coverage Diff             @@
##             main      #30      +/-   ##
==========================================
+ Coverage   65.00%   69.78%   +4.78%     
==========================================
  Files           7        7              
  Lines         500      599      +99     
==========================================
+ Hits          325      418      +93     
- Misses        175      181       +6     
Impacted Files Coverage Δ
src/ci.rs 0.00% <0.00%> (ø)
src/main.rs 1.96% <0.00%> (-0.48%) ⬇️
src/template.rs 94.40% <96.66%> (+21.99%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@hirosassa hirosassa merged commit 675ad0c into main Nov 26, 2022
@hirosassa hirosassa deleted the suppor-target branch November 26, 2022 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants