New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ledger): add utf-8 message signing support #2583
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ffa07d8
to
69d031b
Compare
Made a first pass through, looks like some good improvements while adding the message signing flow. 👍 I saw you moved the routes in with the feature which is interesting. |
69d031b
to
f53d4a2
Compare
f53d4a2
to
01f9a2b
Compare
01f9a2b
to
817a24d
Compare
817a24d
to
6423c88
Compare
6423c88
to
45936d3
Compare
45936d3
to
d8b8c3b
Compare
d8b8c3b
to
d5e7cc4
Compare
d5e7cc4
to
d45b7d0
Compare
d45b7d0
to
87a8509
Compare
87a8509
to
9ad4651
Compare
Maybe it never broke the lines on that screen? It does on the details screen before so was thinking it did. |
Thanks for the feedback @fbwoolf—sorry totally forgot that we're also waiting on these changes in Stacks.js hirosystems/stacks.js#1329 |
9908eb2
to
f230c9e
Compare
f230c9e
to
2c99c9c
Compare
2c99c9c
to
603d9fa
Compare
603d9fa
to
81ad1ad
Compare
81ad1ad
to
fddf99e
Compare
fddf99e
to
aac0eda
Compare
aac0eda
to
022a362
Compare
Fixed, had it not closing for debugging purposes |
This is safe to merge, as it won't change existing behaviour |
This PR adds support for UTF-8 message signing for Ledger.
I've refactored many duplicated components, yet retained an approach where each Ledger interaction is composed of generic components, making use of Route state where action-specific textual changes are needed. The current set up allows each Ledger action to either use the generic component if sufficient, or a bespoke component if necessary.
Todo:
@zondax/ledger-stacks
when published