New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PSBT with an ordinal taproot script path is not signed #3742
Comments
@fbwoolf thoughts here on whether it's probably wallet-side or dev error, and if the latter, have we seen any similar reports with known resolution that we could share / document? |
I haven't seen anyone else report this not working. I would suspect the PSBT is not built correctly when passed to us? Might be worth referencing an implementation by another app that is working? Would be helpful to know the console error returned by the signer lib if the inputs aren't being signed. |
It could be error my side - especially if stripping off the first byte to get the x-only pubkey is incorrect? I have a work around so it's not pressing. From memory were no errors in the console - the psbt was returned unchanged. |
Could it possibly be related to this? #3770 @kyranjamie do we strip the first byte? |
It could be - I was aware of this behaviour but I'm not able to confirm either way right now so happy if you want to close this issue. |
Note we'll add more error handling that should help catch cases like this one here #3804 |
Hey!
I am trying to get the PSBT below signed but it is passed back unchanged from the wallet after openPsbtRequestPopup. The actual PSBT is below.
The commitment to the script paths is the 0th output of this tx: c693c22a8caf9ca83637ea67c3734e66de6916547f38d0a445008d3a6d8c6416
The tap leaf script I'm attempting to spend is;
where pubkey is my ordinal pubkey (userData.profile.btcPublicKey.p2tr) with the first byte removed (the 32 byte x only part).
Note: I've used btc-signer to make this work with a custodial key pair. Miller's code does a byte wise compare of each script - trying to find the pubkey. If found it provides the signature and a finalizable tx - see this tx: 47e334fa40a9e31f0c465718eb94526064c7548196b1ee386ab15d6333ceadec.
The PSBT (hex / base 64);
The text was updated successfully, but these errors were encountered: