Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression Bug #58

Closed
hishamco opened this issue Oct 4, 2020 · 1 comment
Closed

Regression Bug #58

hishamco opened this issue Oct 4, 2020 · 1 comment
Labels
bug

Comments

@hishamco
Copy link
Owner

hishamco commented Oct 4, 2020

I just notice there's a bug when I run the LocalizationSample.Mvc more specifically in

My.Extensions.Localization.Json/src/My.Extensions.Localization.Json/JsonStringLocalizerFactory.cs

Lines 41 to 44 in 9d7893a

var typeName = $"{assemblyName}.{typeInfo.Name}" == typeInfo.FullName
? typeInfo.Name
: typeInfo.FullName.Substring(assemblyName.Length + 1);
var resourcesPath = Path.Combine(PathHelpers.GetApplicationRoot(), GetResourcePath(assembly));

This seems a regression bug from #49
@hishamco hishamco added the bug label Oct 4, 2020
@hishamco
Copy link
Owner Author

hishamco commented Oct 5, 2020

Fixed in #59

@hishamco hishamco closed this as completed Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hishamco