Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localization in startup project doesn't work. #23

Closed
TPIvan opened this issue Mar 3, 2020 · 8 comments
Closed

Localization in startup project doesn't work. #23

TPIvan opened this issue Mar 3, 2020 · 8 comments

Comments

@TPIvan
Copy link

TPIvan commented Mar 3, 2020

Parameter type and json file name in LocalizationSample are inconsistent.
There is

 public void Configure(IApplicationBuilder app, IHostingEnvironment env, IStringLocalizer<Model> localizer)

in Startup class. However the the file name is Startup.fr-FR.json.

Either the file name should be Model.fr-FR.json or the parameter should be IStringLocalizer<Startup>.

@hishamco
Copy link
Owner

hishamco commented Mar 3, 2020

Thanks for reporting this, let me check or submit a PR if you interest

@TPIvan
Copy link
Author

TPIvan commented Mar 3, 2020

I have a copy opened in VS connected to TFS (not git) so PR is a bit difficult for me.

@hishamco
Copy link
Owner

hishamco commented Mar 3, 2020

No problem I will have a look to it now

@hishamco
Copy link
Owner

hishamco commented Mar 3, 2020

@TPIvan the file named Model.fr-FR.json, I don't see an issue with that, could you rebase to the latest bits?

@TPIvan
Copy link
Author

TPIvan commented Mar 3, 2020

I mean the file Startup.fr-FR.json in LocalizationSample/Resources. I think that the name should be (as you have said) Model.fr-FR.json.

@hishamco
Copy link
Owner

hishamco commented Mar 3, 2020

I meant the Model.fr-FR.json which located in LocalizationSample.Resources

Let me do a quick run without changing anything

@TPIvan
Copy link
Author

TPIvan commented Mar 3, 2020

It seems like each of us sees a different file. Please check the image .

@hishamco
Copy link
Owner

hishamco commented Mar 3, 2020

Fixed in a672ac1, I'm sure I pass a Model for a reason, I revise the old commits

Thanks

@hishamco hishamco closed this as completed Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants