Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for hierarchical keys? #76

Closed
stepanStanc opened this issue Jun 15, 2023 · 5 comments · Fixed by #86
Closed

Support for hierarchical keys? #76

stepanStanc opened this issue Jun 15, 2023 · 5 comments · Fixed by #86

Comments

@stepanStanc
Copy link

In version 3.0.1 it was possible to use hierarchical keys (:) thanks to the configurations API that is used https://learn.microsoft.com/en-us/aspnet/core/fundamentals/configuration/?view=aspnetcore-7.0#configuration-keys-and-values. After this issue #29 and this change ecf7169 that stopped being supported in version 3.1.0.

Would it be possible to bring support for this back, or should an alternate approach be taken?

@hishamco
Copy link
Owner

We could think about an alternative solution for this. Feel free to open a PR if you want

@stepanStanc
Copy link
Author

It's possible to either rollback to using the configuration approach, or to replicate the same funcionality for the structured data using the current json parser. What was the motivation for using System.Text.Json instead?

@hishamco
Copy link
Owner

hishamco commented Dec 2, 2023

What was the motivation for using System.Text.Json instead?

This was the plan, there're new APIs that make parsing JSON much easier and more efficient

@hishamco
Copy link
Owner

Sorry @stepanStanc for this taking so long, please remind me is the hierarchical keys used colon in the past, I need to bring this feature back if it's necessary or think about alternative way

@hishamco
Copy link
Owner

Hierarchical keys are back 🚀, please let me know if you have any feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants