Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On The Fly Color Selector Control #573

Closed
4 tasks done
MichaelThomas0721 opened this issue Aug 4, 2023 · 1 comment
Closed
4 tasks done

On The Fly Color Selector Control #573

MichaelThomas0721 opened this issue Aug 4, 2023 · 1 comment
Labels
enhancement: to triage New feature of request pending review by team member

Comments

@MichaelThomas0721
Copy link
Contributor

MichaelThomas0721 commented Aug 4, 2023

Clear and concise description of the problem

As a developer using Histoire I want a colors selector control like the color input that is native in HTML currently so that I can make small color adjustments when customizing my stories on the fly.

Suggested solution

Create a new control type for the color selector, I would suggest a text input box with a color input type beside it so that users can paste hex codes as well as use the color selector.

Alternative

I believe the current alternatives are hard coding colors which doesn't allow for the quick on the fly customization that I am looking for, using a text input for hex codes which is inconvenient for small adjustments, or using pre coded tailwind colors which isn't a good solution for quick small changes.

Additional context

I am planning on submitting a PR for this feature hopefully soon. I haven't worked with VUE very much so it is a little bit of a learning experience for me at the moment, I have a mostly working version with the only problem being that it is very slow since it emits the new value for state extremely frequently, I am not sure if there is a better way to update state in VUE but I am looking into it. If anyone knows the best way to update the state for something like this, let me know :)

Validations

Edit: While scrolling through the issues I saw that this was included on #30 so sorry about the duplicate, it didn't pop up when I searched for it.

@MichaelThomas0721 MichaelThomas0721 added the enhancement: to triage New feature of request pending review by team member label Aug 4, 2023
@MichaelThomas0721
Copy link
Contributor Author

image
Screen shot example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement: to triage New feature of request pending review by team member
Projects
None yet
Development

No branches or pull requests

1 participant