-
-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v0.17.8]]Warning on install with vite 5.0 #662
Comments
Would be great to have another small release containing this fix 🙏 |
@Akryum have you a release date for this fix ? |
Another patch release would be really helpful, considering the fix already exists on |
We must certainly do not want tired maintainers but the community does desire a patch release including the commits made after v0.17.8 was cut. EDIT: It appears perhaps some additional changes may be needed I see now. @Akryum please let me know if there's anything I can do to help and thank you for maintaining this software. 🙏 |
Sorry, I was sure that I released the change but it seems I didn't - it's done now! 🙏 |
Thanks so much! Really appreciate it!! |
Describe the bug
When I try to install (in my case, renovate-bot try to install) new version of histoire with vite 5.0, I gave this warning :
After research, it seems the package
@histoire/shared
have perrDependency and devDependency ofvite
but not with same test versions :histoire/packages/histoire-shared/package.json
Lines 39 to 45 in bc08dec
Reproduction
Try to install histoire v0.17.8 with vite v5.x
System Info
The text was updated successfully, but these errors were encountered: