Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v0.17.8]]Warning on install with vite 5.0 #662

Closed
throrin19 opened this issue Jan 15, 2024 · 6 comments
Closed

[v0.17.8]]Warning on install with vite 5.0 #662

throrin19 opened this issue Jan 15, 2024 · 6 comments
Labels
to triage This issue needs to be triaged

Comments

@throrin19
Copy link

Describe the bug

When I try to install (in my case, renovate-bot try to install) new version of histoire with vite 5.0, I gave this warning :

npm WARN ERESOLVE overriding peer dependency
npm WARN While resolving: @histoire/shared@0.17.8
npm WARN Found: vite@5.0.11
npm WARN node_modules/vite
npm WARN   dev vite@"5.0.11" from the root project
npm WARN   6 more (@vitejs/plugin-vue, histoire, vite-node, ...)
npm WARN 
npm WARN Could not resolve dependency:
npm WARN peer vite@"^2.9.0 || ^3.0.0 || ^4.0.0" from @histoire/shared@0.17.8
npm WARN node_modules/@histoire/shared
npm WARN   @histoire/shared@"^0.17.8" from @histoire/app@0.17.8
npm WARN   node_modules/@histoire/app
npm WARN   3 more (@histoire/controls, @histoire/plugin-vue, histoire)
npm WARN 
npm WARN Conflicting peer dependency: vite@4.5.1
npm WARN node_modules/vite
npm WARN   peer vite@"^2.9.0 || ^3.0.0 || ^4.0.0" from @histoire/shared@0.17.8
npm WARN   node_modules/@histoire/shared
npm WARN     @histoire/shared@"^0.17.8" from @histoire/app@0.17.8
npm WARN     node_modules/@histoire/app
npm WARN     3 more (@histoire/controls, @histoire/plugin-vue, histoire)

After research, it seems the package @histoire/shared have perrDependency and devDependency of vite but not with same test versions :

"peerDependencies": {
"vite": "^2.9.0 || ^3.0.0 || ^4.0.0"
},
"devDependencies": {
"typescript": "^4.9.5",
"vite": "^5.0.7"
}

Reproduction

Try to install histoire v0.17.8 with vite v5.x

System Info

System:
    OS: macOS 13.6.1
    CPU: (8) x64 Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz
    Memory: 44.29 MB / 16.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 20.11.0 - ~/.nvm/versions/node/v20.11.0/bin/node
    npm: 10.2.4 - ~/.nvm/versions/node/v20.11.0/bin/npm
    pnpm: 7.30.0 - /usr/local/bin/pnpm
  Browsers:
    Chrome: 120.0.6099.216
    Edge: 120.0.2210.133
    Safari: 16.6
  npmPackages:
    @histoire/controls: 0.17.8 => 0.17.8
    @histoire/plugin-vue: 0.17.8 => 0.17.8
    @vitejs/plugin-vue: 5.0.3 => 5.0.3 
    histoire: 0.17.8 => 0.17.8
    vite: 5.0.11 => 5.0.11


### Used Package Manager

npm

### Validations

- [X] Follow our [Code of Conduct](https://github.com/histoire-dev/histoire/blob/main/CODE_OF_CONDUCT.md)
- [X] Read the [Contributing Guidelines](https://github.com/histoire-dev/histoire/blob/main/CONTRIBUTING.md).
- [X] Read the [docs](https://histoire.dev/guide/).
- [X] Check that there isn't [already an issue](https://github.com/histoire-dev/histoire/issues) that reports the same bug to avoid creating a duplicate.
- [X] Check that this is a concrete bug. For Q&A open a [GitHub Discussion](https://github.com/histoire-dev/histoire/discussions).
- [X] The provided reproduction is a [minimal reproducible example](https://stackoverflow.com/help/minimal-reproducible-example) of the bug.
@throrin19 throrin19 added the to triage This issue needs to be triaged label Jan 15, 2024
@Akryum Akryum closed this as completed in caa56f9 Jan 15, 2024
@paescuj
Copy link

paescuj commented Jan 17, 2024

Would be great to have another small release containing this fix 🙏

@throrin19
Copy link
Author

@Akryum have you a release date for this fix ?

@feathecutie
Copy link

Another patch release would be really helpful, considering the fix already exists on main. Histoire is still my only blocker for using Vite 5, and thus being able to use SvelteKit 2.

@vhscom
Copy link

vhscom commented Jan 25, 2024

We must certainly do not want tired maintainers but the community does desire a patch release including the commits made after v0.17.8 was cut. EDIT: It appears perhaps some additional changes may be needed I see now.

@Akryum please let me know if there's anything I can do to help and thank you for maintaining this software. 🙏

@Akryum
Copy link
Member

Akryum commented Jan 25, 2024

Sorry, I was sure that I released the change but it seems I didn't - it's done now! 🙏

@vhscom
Copy link

vhscom commented Jan 25, 2024

Thanks so much! Really appreciate it!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
to triage This issue needs to be triaged
Projects
None yet
Development

No branches or pull requests

5 participants