Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Improve Connection.Start and Connection.Finished calls #10
Currently, before accessing the database the connection must be ensured to be opened. This is achieved with the Database.Connection.Start. This call will open the connection if it has not already been opened. Similarly the Database.Connection.Finished call will close the connection if it is the last Finished call. If the Finished call is embedded within the bounds of a Start / Finished call set then the Finished call does nothing, it only decrements a counter.
The issue with this approach is that if an exception occurs the Finished call may not be called (unless it is in the finally section of a try / catch).
A new class should be created called ConnectionScope with a Database argument. The constructor will call the Connection.Start method and the Dispose method will call the Finished method. This will ensure that if an unexpected exception occurs the connection is correctly closed. This should also work when used in conjunction with a System.Transactions.TransactionScope object.
All of the code in the Database class should be updated to utilise this new construct.