Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[!] deprecated usage of implode #95

Closed
ndrwnaguib opened this issue Oct 7, 2020 · 0 comments
Closed

[!] deprecated usage of implode #95

ndrwnaguib opened this issue Oct 7, 2020 · 0 comments
Assignees
@ndrwnaguib
Labels
bug Something isn't working frontend

Comments

@ndrwnaguib
Copy link
Collaborator

Describe the bug
php implode used to accept its parameters in either order, however its deprecated

To Reproduce
Steps to reproduce the behavior:

  1. Create an assignment using Online Judge as the feedback (either with sandbox or sphere-engine)
  2. Submit a code using a student account
  3. Expand the OJ feedback
  4. Check the source code preview

Expected behavior
Expected to preview the source code, however, it shows the implode's deprecation warning

Moodle (please complete the following information):

  • Version [e.g. 3.5-3.9]
@ndrwnaguib ndrwnaguib added bug Something isn't working frontend labels Oct 7, 2020
@ndrwnaguib ndrwnaguib self-assigned this Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ndrwnaguib ndrwnaguib

Labels
bug Something isn't working frontend
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ndrwnaguib