Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix person field for invalid forms, (#2565) #2589

Merged
merged 1 commit into from
May 1, 2024
Merged

Fix person field for invalid forms, (#2565) #2589

merged 1 commit into from
May 1, 2024

Conversation

amaierhofer
Copy link
Contributor

@amaierhofer amaierhofer commented Apr 30, 2024 •
edited

Wrapt den für die Personen Such relevanten Teil des Plugins in einem Stimulus Controller. Das behebt den Bug für das people_field auf dem StandardFormBuilder.

@amaierhofer amaierhofer self-assigned this Apr 30, 2024
@amaierhofer amaierhofer linked an issue Apr 30, 2024 that may be closed by this pull request
EVENT: Kontaktperson Suche ist Flake #2565
Open
@amaierhofer amaierhofer assigned codez and unassigned amaierhofer Apr 30, 2024
@codez
Copy link
Contributor

codez commented May 1, 2024

Betrifft das andere Typeaheads nicht auch? Bzw wie gross wäre der Aufwand, das bisherige javascripts/modules/remote_autocomplete.js ganz aufzuheben?

@codez codez self-requested a review May 1, 2024 07:00
@amaierhofer amaierhofer force-pushed the bug/2565-fix-person-field-remote-autocomplete branch from a7f7235 to bbab1cf Compare May 1, 2024 08:33
@amaierhofer
Copy link
Contributor Author

amaierhofer commented May 1, 2024 •
edited

Nicht automatisch, da das typeahead jetzt anders (via data-controller) registriert wird. Ich kann aber nochmal drüber gehen und schauen, dass ich das anderswo auch noch entsprechend ergänze / anpasse. Oder wir mergen mal so und machen die Anpassungen so wie wir sie finden am master.

Aufwand für komplette Umstellung schätz ich auf 3-5h.

@amaierhofer amaierhofer force-pushed the bug/2565-fix-person-field-remote-autocomplete branch from bbab1cf to 3db50cb Compare May 1, 2024 15:29
@amaierhofer amaierhofer force-pushed the bug/2565-fix-person-field-remote-autocomplete branch from 3db50cb to 8fb4c46 Compare May 1, 2024 15:30
@amaierhofer
Copy link
Contributor Author

Hab jetzt den ganzen bestehenden code in einem stimulus controller gewrapped, das scheint gut zu funktionieren

@amaierhofer amaierhofer merged commit 81499c7 into master May 1, 2024
10 of 11 checks passed
@amaierhofer amaierhofer deleted the bug/2565-fix-person-field-remote-autocomplete branch May 1, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codez codez codez approved these changes

Assignees

@codez codez

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EVENT: Kontaktperson Suche ist Flake
2 participants
@amaierhofer @codez