Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace async with non_blocking for pytorch 1.0 #25

Merged
merged 1 commit into from Dec 20, 2018

Conversation

brettkoonce
Copy link
Contributor

this argument got renamed for pytorch 1.0: https://pytorch.org/docs/stable/notes/cuda.html
can put it into a branch as well if you would like to keep things separate.

@brettkoonce
Copy link
Contributor Author

worked without this on a box with python 3.5 (above was an issue on python 3.7), might be related to the python version?

@hitvoice
Copy link
Owner

This argument seems unnecessary and can be removed for better compatibility. According to the doc,

By default, GPU operations are asynchronous.

This argument only forces non-blocking even with the environment variable CUDA_LAUNCH_BLOCKING=1 (if I understand the doc correctly). So is removing this argument a better solution?

@brettkoonce
Copy link
Contributor Author

You know better than I if it's needed, it certainly can be dropped as well.

I only use the launch blocking flag to force error logging, for what it's worth.

@hitvoice
Copy link
Owner

OK. Could you please remove this flag ("async=True")? After that, I can merge the updated branch.

@brettkoonce
Copy link
Contributor Author

@hitvoice Please review!

@hitvoice hitvoice merged commit c3ea030 into hitvoice:master Dec 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants