New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to package:hive_flutter #698
Conversation
Exporting in a diferent file so users that have created their own Color and TimeOfDay adapters don't get naming conflicts.
Improves pub score by conditionally importing path and path_provider
I forgot Mockito depends on build_runner
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@themisir I have fixed the TimeAdapter issue, have a look now (had to fix the tests too) now I think it is good to go. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about that?
- The old TimeAdapter was stack overflowing. - Renamed TimeAdapter to TimeOfDayAdapter for consistency. - CRUD works now for both color and timeOfDay adapters. Update hive_flutter/lib/src/adapters/time_adapter.dart Co-authored-by: Misir Jafarov <misir.ceferov@gmail.com> - @themisir reduced read/write operation to 1.
@themisir done. |
Closes #691 exporting
Color
andTimeOfDay
adapters:adapters.dart
to avoid naming conflicts for users that define their ownColor
&TimeOfDay
adapters.import 'package:hive_flutter/adapters.dart'
;Improves pub score by conditionally importing packages that depend on
dart:io
(path & path_provider).Tried fixing #688 for null safety badge on pub.dev
flutter pub global run pana
outputs error:flutter pub outdated --mode=null-safety
outputs:@themisir feel free to request changes.