Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make HiveMQ Client OSGi compliant #269

Closed
alexweirig opened this issue Apr 17, 2019 · 3 comments · Fixed by #319
Closed

Make HiveMQ Client OSGi compliant #269

alexweirig opened this issue Apr 17, 2019 · 3 comments · Fixed by #319
Assignees
Milestone

Comments

@alexweirig
Copy link

Hello,

could you please make the client library OSGi compliant be generating a full MANIFEST.MF file with the correct IMPORT and EXPORT packages statements.

This would allow users to deploy the client into an OSGi container (Felix, Equinox, Karaf ...) without any further actions required.

maven has the required plugins to generate valid OSGi bundles. The best and most reliable solution would probably be to use the bnd(tools) plugin for maven.

https://enroute.osgi.org/about/115-bnd-plugins.html

Many thanks in advance

@siepkes
Copy link

siepkes commented Apr 17, 2019

If you have experience with OSGi it might be best to create a PR for it. I don't know if the maintainers of this project have OSGi experience but OSGi can be a bit intimidating if you have never worked with it before.

@dobermai
Copy link
Member

OSGi is not something we‘re using ourselves and we are not aware of current library users with OSGi. We‘re open for contributions, though.

@J-N-K
Copy link
Contributor

J-N-K commented Aug 3, 2019

I'm currently checking if we can use the HiveMQ client in openHAB and we would greatly benefit from an OSGi package.
One question (not very experienced with netty): Do we need excactly 4.1.32.Final or can we use everything from 4.1 to 4.2?

@SgtSilvio SgtSilvio added this to To do in Version 1.1.x via automation Aug 8, 2019
@SgtSilvio SgtSilvio moved this from To do to Review in progress in Version 1.1.x Aug 8, 2019
@SgtSilvio SgtSilvio added this to the 1.1.2 milestone Aug 8, 2019
@SgtSilvio SgtSilvio self-assigned this Aug 8, 2019
Version 1.1.x automation moved this from Review in progress to Done Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Version 1.1.x
  
Done
Development

Successfully merging a pull request may close this issue.

5 participants