Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server support for protocols #26

Merged
merged 129 commits into from Apr 26, 2024
Merged

Server support for protocols #26

merged 129 commits into from Apr 26, 2024

Conversation

joamag
Copy link
Contributor

@joamag joamag commented Jul 4, 2018

Design changes

Current Status

  • Echo UDP server (EchoServerProtocol) already working
  • EchoProtocol is the one used for the testing

What is still missing

  • Proper HTTPserver support (Echo HTTP Server) working

Testing

To run the echo server Protocol implementation using netius run:

PYTHONPATH=. python3 netius/servers/echo.py 

To use the compat version meaning that an asyncio-like interface will be used underneath the hoods use:

COMPAT=1 PYTHONPATH=. python3 netius/servers/echo.py

This PR is related to #23

@coveralls
Copy link

coveralls commented Jul 4, 2018

Coverage Status

Coverage decreased (-0.3%) to 45.515% when pulling b65de59 on protocols/server into 2568f6c on master.

@joamag
Copy link
Contributor Author

joamag commented Jul 5, 2023

There's still part of the server API that is pending implementation.

@joamag
Copy link
Contributor Author

joamag commented Apr 22, 2024

Some initial notes on how to approach the challenge:

  • Define goals - proper assertions to be full filled
  • create some unit tests
  • Build incrementally

@joamag
Copy link
Contributor Author

joamag commented Apr 26, 2024

⚠️ I'm merging this code even though it's currently a work in progress so that we ca move forward with major code re-structure (black format) ⚠️

There should exist an immediate followup PR to re-open the on going work for server implementation.

@joamag joamag merged commit f932f8c into master Apr 26, 2024
14 checks passed
@joamag joamag deleted the protocols/server branch April 26, 2024 10:40
@joamag
Copy link
Contributor Author

joamag commented Apr 26, 2024

⚠️ I'm merging this code even though it's currently a work in progress so that we ca move forward with major code re-structure (black format) ⚠️

There should exist an immediate followup PR to re-open the on going work for server implementation.

CC: @hugo-gomes

@joamag joamag mentioned this pull request Apr 26, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core 💎 Issue belongs to the core development context enhancement New feature or request risky ❕ Seems to be risky
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants