Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor HIMainHack.h #4

Open
mackuba opened this issue Nov 4, 2013 · 2 comments
Open

refactor HIMainHack.h #4

mackuba opened this issue Nov 4, 2013 · 2 comments

Comments

@mackuba
Copy link
Member

mackuba commented Nov 4, 2013

Why is this a header file, not a .c file? /cc @bazyli

@mackuba
Copy link
Member Author

mackuba commented Nov 4, 2013

Apparently this is a copy of main.c file from the Tor submodule, and the reason why it's included as a header is that the file in which it's included uses static functions from this file. To do it differently we'd need to copy the functions we need to another .c file as not static and then keep them in sync with the versions in main.c when it changes (but since it's already a copy of the file, it wouldn't be much different than what we have now...).

@chrisballinger
Copy link

I've done this in my fork: https://github.com/chatsecure/onionkit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants