Doorbell not always triggering

[denniedegroot]

Describe The Problem:
The G4 doorbell is not always triggering. This is due to the following line:

homebridge-unifi-protect/src/protect-nvr-events.ts

Line 212 in 3552015

return;

A payload can contain both a lastMotion and lastRing object. So the "return" needs to be deleted.

To Reproduce:
Dance before the G4 Doorbell and press the button.

Logs:
Both JSON messages when a doorbell is pressed with and without motion detected:

{ lastRing: 1612884026670 }

{
  lastMotion: 1612883092648,
  isMotionDetected: true,
  lastRing: 1612883093292
}

[github-actions]

@denniedegroot - this issue is being automatically closed because it does not follow either the feature request or bug report issue template. The issue templates have been designed to help in the troubleshooting (or feature request) process. Please use them and populate it as completely as possible to streamline troubleshooting or feature request discussions.

[hjdhjd]

Appreciate it. It’s a recent change that occurred in the last two revisions for Protect. This is already fixed in my tree and will be in a future update. Thanks!

[github-actions]

This issue is locked to prevent necroposting on closed issues. Please create a new issue for related support requests, bug reports, or feature suggestions.