Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ChildRecordData syncing across projections seems like it can end up in bad states #885

Closed
igorT opened this issue Sep 24, 2020 · 2 comments

Comments

@igorT
Copy link
Collaborator

igorT commented Sep 24, 2020

In general we rely on keeping one copy of canonical data in a baseRecordData, and then having projections modify and read from the baseRecordData. This in general works, but in cases of nested records and nested arrays, we also have childRecordDatas in both baseRecordData and the projection. While changing individual properties on those nested records will work, if you add or remove entire records from the array childRecordDatas might get out of sync between the base and projection records. I fixed one of the issues in #884 but it's likely there are more similar ones.

@hjdivad
Copy link
Collaborator

hjdivad commented Sep 25, 2020

@igorT can we add tests to confirm whether this issue is fully resolved by #884 or if we have additional gaps?

@igorT
Copy link
Collaborator Author

igorT commented Sep 25, 2020

This issue is to track adding more tests/investigating if there are more issues

@hjdivad hjdivad closed this as completed Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants