Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add array native access #1238

Merged
merged 3 commits into from Jul 30, 2021
Merged

Add array native access #1238

merged 3 commits into from Jul 30, 2021

Conversation

igorT
Copy link
Collaborator

@igorT igorT commented Jul 30, 2021

Allows managed arrays to be used as native JS arrays. Removes PROXY_MODEL_CLASS feature flag, due to a different implementation for object dot access compared to the one that was feature flagged.

@igorT igorT added the enhancement ch:enhancement label Jul 30, 2021
@github-actions
Copy link

github-actions bot commented Jul 30, 2021

Performance Report for 3a5b7a4

Scenario - materializing: ✅ Performance improved

✅ duration
phase estimated improvement -77ms [-126ms to -28ms] OR -1.03% [-1.69% to -0.38%]
☑️ Phase [navigationStart] => [start-loading]
phase no difference [-7ms to 3ms]
☑️ Phase [start-loading] => [pushed-payload]
phase no difference [-11ms to 30ms]
✅ Phase [pushed-payload] => [end-loading]
phase estimated improvement -78ms [-112ms to -47ms] OR -2.61% [-3.76% to -1.57%]
☑️ Phase [end-loading] => [Test End]
phase no difference [-4ms to 4ms]

Scenario - rendering: ☑️ Performance is stable

☑️ duration
phase no difference [-12ms to 21ms]
☑️ Phase [navigationStart] => [start-loading]
phase no difference [-3ms to 6ms]
⚠️ Phase [start-loading] => [pushed-payload]
phase estimated regression +2ms [1ms to 3ms] OR +1.69% [0.64% to 2.82%]
☑️ Phase [pushed-payload] => [end-loading]
phase no difference [0ms to 0ms]
☑️ Phase [end-loading] => [Test End]
phase no difference [-12ms to 14ms]

Copy link
Contributor

@gitstevenpham gitstevenpham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@igorT igorT merged commit c40fc81 into master Jul 30, 2021
@igorT igorT deleted the igor/array-dot-access branch July 30, 2021 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ch:enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants