Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation for native property access #1252

Merged
merged 4 commits into from Aug 2, 2021
Merged

Add documentation for native property access #1252

merged 4 commits into from Aug 2, 2021

Conversation

igorT
Copy link
Collaborator

@igorT igorT commented Aug 2, 2021

No description provided.

@igorT igorT added the documentation ch:documentation label Aug 2, 2021
gitstevenpham
gitstevenpham reviewed Aug 2, 2021
View reviewed changes
DEPRECATIONS.md Outdated Show resolved Hide resolved
gitstevenpham
gitstevenpham reviewed Aug 2, 2021
View reviewed changes
DEPRECATIONS.md Outdated Show resolved Hide resolved
gitstevenpham
gitstevenpham reviewed Aug 2, 2021
View reviewed changes
README.md Outdated Show resolved Hide resolved
@igorT @gitstevenpham
Update README.md
73e0f76 
Co-authored-by: Steven Pham <2080348+spham92@users.noreply.github.com>
gitstevenpham
gitstevenpham approved these changes Aug 2, 2021
View reviewed changes
Copy link
Contributor

@gitstevenpham gitstevenpham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions
Copy link

github-actions bot commented Aug 2, 2021 •
edited

Performance Report for 73e0f76

Scenario - materializing: ☑️ Performance is stable

☑️ duration
phase no difference [-8ms to 87ms]
☑️ Phase [navigationStart] => [start-loading]
phase no difference [-2ms to 10ms]
☑️ Phase [start-loading] => [pushed-payload]
phase no difference [-13ms to 40ms]
☑️ Phase [pushed-payload] => [end-loading]
phase no difference [-2ms to 44ms]
☑️ Phase [end-loading] => [Test End]
phase no difference [0ms to 1ms]

Scenario - rendering: ☑️ Performance is stable

☑️ duration
phase no difference [-15ms to 14ms]
☑️ Phase [navigationStart] => [start-loading]
phase no difference [-6ms to 3ms]
☑️ Phase [start-loading] => [pushed-payload]
phase no difference [-1ms to 2ms]
☑️ Phase [pushed-payload] => [end-loading]
phase no difference [0ms to 0ms]
☑️ Phase [end-loading] => [Test End]
phase no difference [-11ms to 12ms]

@igorT igorT merged commit 6ff647d into master Aug 2, 2021
@igorT igorT deleted the igor/native-prop-docs branch August 2, 2021 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gitstevenpham gitstevenpham gitstevenpham approved these changes

@hjdivad hjdivad Awaiting requested review from hjdivad

Assignees
No one assigned
Labels
documentation ch:documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@igorT @gitstevenpham