Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IE testing and guard proxies when they are not present #1315

Merged
merged 12 commits into from Sep 2, 2021
Merged

Conversation

igorT
Copy link
Collaborator

@igorT igorT commented Sep 1, 2021

We were not testing against IE11, and a few failures had snuck in. We now only create m3 array proxies when we are able to instantiate a Proxy class, similarly to how Ember does it https://github.com/emberjs/ember.js/blob/v3.28.0/packages/@ember/-internals/utils/lib/proxy-utils.ts

@github-actions
Copy link

github-actions bot commented Sep 1, 2021

Performance Report for 28856cc

Scenario - materializing: ✅ Performance improved

✅ duration
phase estimated improvement -61ms [-104ms to -17ms] OR -1.09% [-1.86% to -0.31%]
☑️ Phase [navigationStart] => [start-loading]
phase no difference [-3ms to 9ms]
✅ Phase [start-loading] => [pushed-payload]
phase estimated improvement -40ms [-67ms to -15ms] OR -1.29% [-2.16% to -0.47%]
✅ Phase [pushed-payload] => [end-loading]
phase estimated improvement -21ms [-41ms to -2ms] OR -0.97% [-1.9% to -0.12%]
☑️ Phase [end-loading] => [Test End]
phase no difference [-1ms to 1ms]

Scenario - rendering: ☑️ Performance is stable

☑️ duration
phase no difference [-13ms to 16ms]
☑️ Phase [navigationStart] => [start-loading]
phase no difference [-3ms to 6ms]
☑️ Phase [start-loading] => [pushed-payload]
phase no difference [-1ms to 2ms]
☑️ Phase [pushed-payload] => [end-loading]
phase no difference [0ms to 1ms]
☑️ Phase [end-loading] => [Test End]
phase no difference [-14ms to 7ms]

fetch polyfill
@igorT igorT changed the title Add IE testing Add IE testing and guard proxies when they are not present Sep 2, 2021
@igorT igorT marked this pull request as ready for review September 2, 2021 00:22
tests/dummy/app/adapters/-json-api.js Show resolved Hide resolved
package.json Show resolved Hide resolved
@igorT igorT added the bug ch:bugfix label Sep 2, 2021
@igorT
Copy link
Collaborator Author

igorT commented Sep 2, 2021

@hjdivad gave 👍 over slack

@igorT igorT merged commit 68208d6 into master Sep 2, 2021
@igorT igorT deleted the igor/ie-test branch September 2, 2021 01:20
igorT added a commit that referenced this pull request Sep 2, 2021
We were not testing against IE11, and a few failures had snuck in. We now only create m3 array proxies when we are able to instantiate a Proxy class, similarly to how Ember does it https://github.com/emberjs/ember.js/blob/v3.28.0/packages/@ember/-internals/utils/lib/proxy-utils.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ch:bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants