New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix property access in production and turn on prod testing #1376
Conversation
8182182
to
bc29940
Compare
bc29940
to
5a77369
Compare
Performance Report for 38045f2 Scenario - materializing-lots: ☑️ Performance is stable
Scenario - materializing-small: ☑️ Performance is stable
Scenario - rendering: ☑️ Performance is stable
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, only real complaint is let's update the comment in the proxy as the code is a little tricky and it depends on particular details of Ember.get
b48ba9f
to
38045f2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM please combine the commits before merging so we have clean commit history
Fixes #1371