Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default Icon component warning: v-html directive can lead to XSS attack #101

Open
misspia opened this issue Oct 18, 2019 · 1 comment
Open

Default Icon component warning: v-html directive can lead to XSS attack #101

misspia opened this issue Oct 18, 2019 · 1 comment

Comments

@misspia
Copy link

misspia commented Oct 18, 2019

When running yarn lint, the following warning message from the template's predefined Icon component persists:
Screenshot 2019-10-18 at 13 57 27

Since the component comes with the template, the warning for that line in particular should either be ignored by the linter or resolved
@ThaNarie
Copy link

Since we have total control over what goes in there, I think in this case a lint-ignore would be fine.

Are you okay to create a PR for this? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ThaNarie @misspia