Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create post improvement #305

Merged
merged 17 commits into from
Jul 11, 2023
Merged

Conversation

MrAntonS
Copy link
Contributor

@MrAntonS MrAntonS commented Jul 9, 2023

Upload image works like it should, I use one "Upload image button" for both uploading image to the URL and to the text body(It switches automatically). I did so because the markdown widget does not support custom actions, or i couldn't find any information on how to do so. Also, currently markdown preview doesn't work, this is not my bug, since it doesn't work on the latest release as well. Please review this code and make any necessary changes 😄

@MrAntonS
Copy link
Contributor Author

If anyone in here codes in VScode, please let me know how to fully disable auto formatting with flutter extension

@MrAntonS
Copy link
Contributor Author

Here how it looks depending on if error was caught or nsfw is selected, how image is included in the body.

photo_4_2023-07-09_22-25-57
photo_3_2023-07-09_22-25-57
photo_2_2023-07-09_22-25-57
photo_1_2023-07-09_22-25-57

@hjiangsu
Copy link
Member

I'll switch this to target develop! I'll have to take a closer look at the changes later

@hjiangsu hjiangsu changed the base branch from main to develop July 10, 2023 16:06
@MrAntonS
Copy link
Contributor Author

MrAntonS commented Jul 10, 2023

I tried other media types, but if i try to attach mp4 it's unsupported at the server side, gifs are supported but server converts them to MP4 and now client cannot support them XD, so attaching other media types might be a problem, however if we implement media player it should be easy.

@hjiangsu
Copy link
Member

I have an idea for how to implement a media player, but the package used only supports iOS and Android, which might limit compatibility: https://pub.dev/packages/video_player

If we can find a more universal video player, then I might be able to tackle that

@MrAntonS
Copy link
Contributor Author

For now I think it's OK, we can add a checker and if the type is not image or gif then display link instead of preview

@hjiangsu hjiangsu merged commit 1876d9c into thunder-app:develop Jul 11, 2023
@MrAntonS MrAntonS mentioned this pull request Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants