-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create post improvement #305
Create post improvement #305
Conversation
… working on server uploading
672919e
to
a93e0f7
Compare
If anyone in here codes in VScode, please let me know how to fully disable auto formatting with flutter extension |
3a4ed8c
to
e82e9aa
Compare
I'll switch this to target develop! I'll have to take a closer look at the changes later |
I tried other media types, but if i try to attach mp4 it's unsupported at the server side, gifs are supported but server converts them to MP4 and now client cannot support them XD, so attaching other media types might be a problem, however if we implement media player it should be easy. |
I have an idea for how to implement a media player, but the package used only supports iOS and Android, which might limit compatibility: https://pub.dev/packages/video_player If we can find a more universal video player, then I might be able to tackle that |
For now I think it's OK, we can add a checker and if the type is not image or gif then display link instead of preview |
Upload image works like it should, I use one "Upload image button" for both uploading image to the URL and to the text body(It switches automatically). I did so because the markdown widget does not support custom actions, or i couldn't find any information on how to do so. Also, currently markdown preview doesn't work, this is not my bug, since it doesn't work on the latest release as well. Please review this code and make any necessary changes 😄