Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken test/helperFuncs.py #134

Closed
ralf-meyer opened this issue Feb 20, 2023 · 0 comments
Closed

Broken test/helperFuncs.py #134

ralf-meyer opened this issue Feb 20, 2023 · 0 comments

Comments

@ralf-meyer
Copy link
Member

The merge in 79b8b1e introduced some problematic typos into the test suite. The functions compareNumAtoms(xyz1, xyz2) and compareMLBL(xyz1, xyz2) actually do not compare the two geometries. Instead they just compare xyz1 to itself. Correcting this typo results in several failed tests hinting at either bad tests or some bugs in structgen.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ralf-meyer