Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crashing at save #188

Closed
Emilianenko opened this issue May 1, 2017 · 9 comments
Closed

Crashing at save #188

Emilianenko opened this issue May 1, 2017 · 9 comments

Comments

@Emilianenko
Copy link

when i use the toll remove all unreachable tiles ,and try to save the map, he crashes at 99% =(

@bpawel10
Copy link

bpawel10 commented Dec 21, 2017

I can confirm I have the same issue. It seems number of removed tiles matter, map with about 1kk tiles removed was saved successfully but when I tried to save a map with almost 1.8kk tiles removed, the editor crashed.

@Costallat
Copy link
Collaborator

Costallat commented Aug 7, 2018

The problem is when it removes some tile that have some creature or spawn on it.

I had this problem because I downloaded one map from the internet that had creatures and spawns that were located in the middle of the wall.

@Costallat
Copy link
Collaborator

@hjnilsson can you give me permission to commit?

I have a small fix for this.

Tks.

@hampusborgos
Copy link
Owner

Added as a contributor. :)

@bpawel10
Copy link

bpawel10 commented Aug 9, 2018

Why doesn't he just create pull request?

@Costallat
Copy link
Collaborator

@bpawel10 I tried, but Github didn't allowed me to push my branch to create the PR.

@bpawel10
Copy link

bpawel10 commented Aug 9, 2018

So you probably did it wrong way. As far as I know you should fork this repo and push your branch there.

@gpedro
Copy link
Collaborator

gpedro commented Aug 9, 2018

@dalkon fork this repository, if already cloned the project, change origin url to fork url and push your branch.

@Costallat
Copy link
Collaborator

@bpawel10 So it's not that I did it wrong, I just didn't followed the Github process.

@gpedro Thanks for the explanation.

So I created a file to be used to reproduce the problem, you can open that map, clean it with the "unreachable tile" feature, and it will crash when you save it.

crash.map.tar.gz

#236

This is a v.0.1 version to the fix, as it doesn't show any message to inform the user that his map has those wrong spawn points, but it avoids the crash.

@gpedro gpedro closed this as completed Jun 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants