Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjust the display title length and cover size #23

Closed
WROIATE opened this issue Mar 26, 2020 · 11 comments
Closed

adjust the display title length and cover size #23

WROIATE opened this issue Mar 26, 2020 · 11 comments
Labels
enhancement New feature or request

Comments

@WROIATE
Copy link
Contributor

WROIATE commented Mar 26, 2020

Is your feature request related to a problem? Please describe.
Some manga have a long title length same as a light novel:) Hence display the full title is not a good choice. And the manga cover size have the same problem, because of the different size of manga's first image. It could be too wide or too short

Describe the solution you'd like
create a unified display length and size for title and cover

Additional context
Such as Komga, it's a good example on this problem

@WROIATE WROIATE added the enhancement New feature or request label Mar 26, 2020
@DuraMorte
Copy link

This sounds virtually identical to #20.

@WROIATE
Copy link
Contributor Author

WROIATE commented Mar 27, 2020

This sounds virtually identical to #20.

There have some differences that I want to change the display size of cover with css but you'd like to change the cover's URL. Also I want to shorten title length use ellipsis like Komga and don't want rename it. In other words, it is not a same issue.

@hkalexling
Copy link
Member

I want to shorten title length use ellipsis like Komga

I agree this would improve the user experience. I will work on it soon.

because of the different size of manga's first image. It could be too wide or too short

We do have a CSS rule to restrict the maximum height of the thumbnails. Is this what you are looking for? It would be great if you could provide a more concrete example (preferably with screenshots).

@WROIATE
Copy link
Contributor Author

WROIATE commented Mar 29, 2020

I want to shorten title length use ellipsis like Komga

I agree this would improve the user experience. I will work on it soon.

because of the different size of manga's first image. It could be too wide or too short

We do have a CSS rule to restrict the maximum height of the thumbnails. Is this what you are looking for? It would be great if you could provide a more concrete example (preferably with screenshots).

For example:
This is Komga
Snipaste_2020-03-29_17-08-13
This is Mango
Snipaste_2020-03-29_17-07-13

I think it's a good idea to resize the cover. And you could display the left half image of the long picture by checking the origin picture size.

@hkalexling
Copy link
Member

hkalexling commented Mar 30, 2020

Thanks for the clarification.

I don't think what Komga does is very elegant. In your screenshot, the first half of the title is missing, and the image resolution if low because only a portion of it is shown. I think it would be better to keep it this way, but add #20 so you can manually upload a cover image with the desired size.

@WROIATE
Copy link
Contributor Author

WROIATE commented Mar 30, 2020

Thanks for the clarification.

I don't think what Komga does is very elegant. In your screenshot, the second half of the title is missing, and the image resolution if low because only a portion of it is shown. I think it would be better to keep it this way, but add #20 so you can manually upload a cover image with the desired size.

I guess Komga generate a thumbnail make it so blurry, in fact the picture resolution is high...

Sometimes this cover displayed too small (like mobile devices) that can't see anything and will create a huge gap between the two pictures like this:
Snipaste_2020-03-30_18-44-18
How about resize it with same height? such as:
Snipaste_2020-03-30_18-35-24
Also it looks good on the mobile devices:
Snipaste_2020-03-30_18-35-55

If you desire to solve it with upload a cover, I suggest to Integrate some scraping API like Douban and Google to get the manga information. The example is calibre-web.

@hkalexling
Copy link
Member

This looks nice! I will try it out and see how it works.

Do you mind sharing the CSS you used to get the result? Again feel free to submit a PR to the dev branch if you want.

@WROIATE
Copy link
Contributor Author

WROIATE commented Mar 31, 2020

This looks nice! I will try it out and see how it works.

Do you mind sharing the CSS you used to get the result? Again feel free to submit a PR to the dev branch if you want.

Unfortunately, the css style I just use chrome to edit the single div element but not code a css file for web.

@hkalexling
Copy link
Member

@WROIATE Just to keep you updated, I tried the fixed height strategy you proposed. Unfortunately in most cases it doesn't produce the great result as shown in your screenshots above.

I then tried the Komga approach and it's actually much better than I thought:

Before:
Screen Shot 2020-04-01 at 12 58 51 PM

After:
Screen Shot 2020-04-01 at 12 55 57 PM

In the second screenshot, we fix the height of the cover images and titles, so the cards have the exact same size and the overall layout is much cleaner. But of course, the trade-off is that sometimes only the center part of the cover image is visible.

I will probably tweak it a bit more and make a new release soon. Feel free to let me know what you think!

@WROIATE
Copy link
Contributor Author

WROIATE commented Apr 1, 2020

@WROIATE Just to keep you updated, I tried the fixed height strategy you proposed. Unfortunately in most cases it doesn't produce the great result as shown in your screenshots above.

I then tried the Komga approach and it's actually much better than I thought:

Before:
Screen Shot 2020-04-01 at 12 58 51 PM

After:
Screen Shot 2020-04-01 at 12 55 57 PM

In the second screenshot, we fix the height of the cover images and titles, so the cards have the exact same size and the overall layout is much cleaner. But of course, the trade-off is that sometimes only the center part of the cover image is visible.

I will probably tweak it a bit more and make a new release soon. Feel free to let me know what you think!

Perhaps left justify the long image in the container or crop it in the web backstage will solve the display question of center part cover. You could identify the long picture at backstage and switch the display way.

@hkalexling
Copy link
Member

Perhaps left justify the long image in the container or crop it in the web backstage will solve the display question of center part cover.

This might not work in some cases (see the following screenshot). I think I will leave it like this for now. I will work on #20 soon, and once the feature is added, you can simply upload a cover image with the desired size.

The requested features in this issue are now available in v0.2.4 so I am closing this. Feel free to reopen if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants